fix: declare live wallpaper support as a required feature - #39
Merged
Conversation
Android Go edition and stripped OEM ROMs ship without live wallpaper support, so Weatherd cannot function on them at all. Without a uses-feature declaration Play offered the app to those devices anyway, which produced install-then-fail reports from users who never had a working path. Declaring android.software.live_wallpaper as required lets Play filter the app out for those devices up front, complementing the runtime fallback that shows a toast when no wallpaper chooser resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A 1-star Play review came in from a Tecno Pouvoir 3 Air running Android 9 (Go edition), on version code 9. Android Go and stripped OEM ROMs ship without live wallpaper support, so Weatherd cannot function on them at all.
With no
uses-featuredeclaration, Play offered the app to those devices anyway. Users installed it, hit theActivityNotFoundExceptionfixed in #38, and had no working path to the feature the app exists for.Solution
Declare
android.software.live_wallpaperas a required feature so Play filters Weatherd out of search and installs for devices lacking live wallpaper support.This complements the runtime handling from #38 rather than replacing it: the fallback toast still covers any device that slips through the store-level filter.
Trade-off
This shrinks the eligible device pool. Existing installs on now-ineligible devices will show as incompatible for future updates. Since the app cannot work on those devices regardless, blocking the install up front is preferable to a crash or a dead-end toast.
Verification
./gradlew :app:processDebugMainManifestmerges cleanly, with the element present in the merged manifest.